[libcxx-commits] [PATCH] D113161: [libc++] Implement P1989R2: range constructor for string_view

Joe Loser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Nov 23 08:34:13 PST 2021


jloser added a comment.

I've verified this change doesn't break llvm, so the bug mentioned in



================
Comment at: libcxx/test/std/input.output/filesystems/class.path/range_concept_conformance.compile.pass.cpp:12
 // UNSUPPORTED: libcpp-has-no-incomplete-ranges
+// ADDITIONAL_COMPILE_FLAGS: -fno-delayed-template-parsing
 
----------------
@ldionne @Mordante @Quuxplusone I think this will be needed to make `clang-cl` happy with this test. However, GCC doesn't understand this this compiler flag:


> g++-11: error: unrecognized command-line option '-fno-delayed-template-parsing'

What's the syntax to make this additional compile flag only apply to `clang-cl` case?




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113161/new/

https://reviews.llvm.org/D113161



More information about the libcxx-commits mailing list