[libcxx-commits] [PATCH] D114385: [libunwind] Fix testing with sanitizers enabled

[Louis Dionne via Phabricator via libcxx-commits]

ldionne created this revision.
Herald added a project: libunwind.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libunwind.
ldionne requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

When testing with sanitizers enabled, we need to link against a plethora
of system libraries. Using `-nodefaultlibs` like we used to breaks this,
and we would have to add all these system libraries manually, which is
not portable and error prone. Instead, stop using `-nodefaultlibs` so
that we get the libraries added by default by the compiler.

The only caveat with this approach is that we are now relying on the
fact that `-L <path-to-local-libunwind>` will cause the just built
libunwind to be selected before the system implementation (either of
libunwind or libgcc_s.so), which is somewhat fragile.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D114385

Files:
  libunwind/test/configs/llvm-libunwind-shared.cfg.in
  libunwind/test/configs/llvm-libunwind-static.cfg.in
  libunwind/test/forceunwind.pass.cpp
  libunwind/test/frameheadercache_test.pass.cpp
  libunwind/test/libunwind_01.pass.cpp
  libunwind/test/libunwind_02.pass.cpp
  libunwind/test/remember_state_leak.pass.sh.s
  libunwind/test/signal_frame.pass.cpp
  libunwind/test/signal_unwind.pass.cpp
  libunwind/test/unw_getcontext.pass.cpp
  libunwind/test/unwind_leaffunction.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D114385.388989.patch
Type: text/x-patch
Size: 5314 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20211122/3afa7a46/attachment.bin>