[libcxx-commits] [PATCH] D114281: [libc++] Granularize the <random> header.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM with comment.

As usual with these patches, I'm assuming you did not modify anything at all except what you called out. I'm fine with the `<concepts>` removal from `<random>` -- I agree it's unlikely people have started depending on that.



================
Comment at: libcxx/include/__random/binomial_distribution.h:21-22
+
+_LIBCPP_PUSH_MACROS
+#include <__undef_macros>
+
----------------
I haven't checked whether that's the case or not, but please only do this when the file uses `min()` or `max()`. If that's already the case, then ignore this comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114281/new/

https://reviews.llvm.org/D114281