[libcxx-commits] [PATCH] D114281: [libc++] Granularize the <random> header.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added a comment.

In D114281#3146565 <https://reviews.llvm.org/D114281#3146565>, @philnik wrote:

> Since you move the stuff around anyways, maybe now it would be a good time to reformat it?

One answer is "As a rule, we shouldn't cut-and-paste-around huge amounts of code //and// change code in the same patch" (because that makes the chunks harder to diff and thus the movements harder to track).
My preferred answer, though, is "I see no reason to //ever// reformat this code": it looks mostly well formatted to me. (There are a few exceptions, like lines 88–89 of `weibull_distribution.h`, but I don't think clang-format would be likely to improve the situation even in that specific case.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114281/new/

https://reviews.llvm.org/D114281