[libcxx-commits] [PATCH] D114282: [libc++] Remove uses of printf in some test support headers

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Nov 22 09:00:58 PST 2021


ldionne added a comment.

In D114282#3143945 <https://reviews.llvm.org/D114282#3143945>, @Quuxplusone wrote:

> Seems fine. Although I wonder if we could go further: These functions that check a bunch of stuff and return true-or-false, could they instead just //assert// all that stuff and return void?

That would be more difficult since several tests use the return value of these functions to do more than just `assert`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114282/new/

https://reviews.llvm.org/D114282



More information about the libcxx-commits mailing list