[libcxx-commits] [PATCH] D113161: [libc++] Implement P1989R2: range constructor for string_view

[Joe Loser via Phabricator via libcxx-commits]

jloser added a comment.

In D113161#3145182 <https://reviews.llvm.org/D113161#3145182>, @Quuxplusone wrote:

> Here's a reduced test case, as I understand the issue to be: https://godbolt.org/z/qcaf76EbW
> Uncomment `internalDetail(StringView)` to see things blow up on Clang and GCC.
> Expect a blog post about this, soon. ;)

Nice reduced test case! I think this is *close* but not exact, right? In your Godbolt,

  static_assert(std::ranges::range<const Path>);

passes, but

  static_assert(std::ranges::range<Path>);

produces the hard error. This is the //inverse// of the problem we hit here in `libc++`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113161/new/

https://reviews.llvm.org/D113161