[libcxx-commits] [PATCH] D93408: [CMake] Split the target side of runtimes build

[Kazushi Marukawa via Phabricator via libcxx-commits]

kaz7 added a comment.
Herald added projects: libc++, libc++abi.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.
Herald added a reviewer: libc++abi.

I am looking at codes around this and have noticed this glitch.  Others like `$(name)_extra_args` are initialized with `set(${name}_extra_args ${ARG_CMAKE_ARGS})`.



================
Comment at: llvm/runtimes/CMakeLists.txt:102
+  check_apple_target(${target} builtin)
 
+  get_cmake_property(variableNames VARIABLES)
----------------
Don't we need `set(${target}_extra_args ${ARG_CMAKE_ARGS})` here to initialize `$(target)_extra_args`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93408/new/

https://reviews.llvm.org/D93408