[libcxx-commits] [PATCH] D114248: [libc++] Improve CMake include directory search.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libcxx/src/CMakeLists.txt:200
   add_library(cxx_shared SHARED ${exclude_from_all} ${LIBCXX_SOURCES} ${LIBCXX_HEADERS})
+  target_include_directories(cxx_shared PRIVATE ${CMAKE_CURRENT_SOURCE_DIR})
   target_link_libraries(cxx_shared PUBLIC cxx-headers
----------------
Mordante wrote:
> ldionne wrote:
> > What are these useful for?
> Basically it's based on the comment https://reviews.llvm.org/D70631#inline-1071881. In that original version I used the blunt tool of `include_directories(${CMAKE_CURRENT_SOURCE_DIR})`. Without this the `ryu` related headers can't be found.
Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114248/new/

https://reviews.llvm.org/D114248