[libcxx-commits] [PATCH] D114010: [libc++] Properly handle errors happening during Lit configuration

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D114010#3143964 <https://reviews.llvm.org/D114010#3143964>, @Quuxplusone wrote:

> I'd just done `print(err)` on old line 210, in my local checkout, but I assume your `raise` is better. :)

Well, the benefit is that the exception will bubble up all the way and end Lit configuration, which is really what we want. And then its payload (the string) will be printed, which is also what we want.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114010/new/

https://reviews.llvm.org/D114010