[libcxx-commits] [PATCH] D114243: [libc++] Fix feature test macro for __cpp_lib_to_chars

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D114243#3143509 <https://reviews.llvm.org/D114243#3143509>, @ldionne wrote:

> In D114243#3143089 <https://reviews.llvm.org/D114243#3143089>, @Mordante wrote:
>
>> Nice catch. LGTM, I would be slightly concerned about removing it from the `<utility>` header if the feature were completely implemented.
>
> Yeah, agreed, luckily it has never been defined.

Well I have to disagree with that assessment, I would have loved us to have completed C++17 support by now.
(/me will try to complete to_chars float real soon now.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114243/new/

https://reviews.llvm.org/D114243