[libcxx-commits] [PATCH] D114243: [libc++] Fix feature test macro for __cpp_lib_to_chars

Fri Nov 19 11:26:23 PST 2021

ldionne added a comment.

In D114243#3142923 <https://reviews.llvm.org/D114243#3142923>, @Quuxplusone wrote:

>> should go, do you agree?
>
> Definitely, yes. You might do one more pass through wherever the feature-test macros are standardized, just to see if there's anything else that should be defined in `<charconv>` that we've missed.

That's the only FTM in `<charconv>` AFAICT: http://eel.is/c++draft/version.syn

In D114243#3143089 <https://reviews.llvm.org/D114243#3143089>, @Mordante wrote:

> Nice catch. LGTM, I would be slightly concerned about removing it from the `<utility>` header if the feature were completely implemented.

Yeah, agreed, luckily it has never been defined.

Thank you both!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114243/new/

https://reviews.llvm.org/D114243