[libcxx-commits] [PATCH] D107036: [WIP] [libc++] [P1614] Various unimplemented parts of <compare>. [WIP]

Fri Nov 19 08:05:12 PST 2021

ldionne added inline comments.

================
Comment at: libcxx/test/std/library/description/conventions/type.descriptions/customization.point.object/cpo.pass.cpp:1
+//===----------------------------------------------------------------------===//
+//
----------------
Quuxplusone wrote:
> This one test file is the only part of D107036 that hasn't been superseded by D110738 + D111514.
> @ldionne or whoever, do you think we care about this test file? Should I open a new PR for it (or repurpose this one)? or should I just close D107036 completely?
I think this test is useful, and I would encourage splitting it into another PR to clear things up a bit. And then we can close this one as it has been superseded.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107036/new/

https://reviews.llvm.org/D107036