[libcxx-commits] [PATCH] D114243: [libc++] Remove obsolete feature test macro tests

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D114243#3142866 <https://reviews.llvm.org/D114243#3142866>, @Quuxplusone wrote:

> This smelled fishy to me so I investigated a tiny bit. I believe we're defining `__cpp_lib_to_chars` in the wrong header (`utility` should be `charconv`). I didn't dig deeper than that, but I'd encourage you to. :)

You seem to be right (http://eel.is/c++draft/version.syn#lib:__cpp_lib_to_chars). Let me correct that.

But nonetheless, these manually written tests should go, do you agree?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114243/new/

https://reviews.llvm.org/D114243