[libcxx-commits] [PATCH] D114136: [libc++] Test that our algorithms never copy a user-provided comparator.

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Nov 18 14:20:43 PST 2021


Quuxplusone updated this revision to Diff 388325.
Quuxplusone added a comment.

Aaargh. Fourth time's the charm.
(Also, GCC was complaining about the one-line `if (!TEST_IS_CONSTEXPR) (void)foo(); assert(bar);` so I added curly braces to them.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114136/new/

https://reviews.llvm.org/D114136

Files:
  libcxx/include/__algorithm/binary_search.h
  libcxx/include/__algorithm/is_heap.h
  libcxx/include/__algorithm/is_heap_until.h
  libcxx/include/__algorithm/is_sorted.h
  libcxx/include/__algorithm/is_sorted_until.h
  libcxx/include/__algorithm/max.h
  libcxx/include/__algorithm/max_element.h
  libcxx/include/__algorithm/min.h
  libcxx/include/__algorithm/min_element.h
  libcxx/test/libcxx/algorithms/robust_against_copying_comparators.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D114136.388325.patch
Type: text/x-patch
Size: 21084 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20211118/6c87650e/attachment-0001.bin>


More information about the libcxx-commits mailing list