[libcxx-commits] [PATCH] D113612: [libc++] Value-initialize unique_ptr's deleter_type

Thu Nov 18 13:53:05 PST 2021

bergjohan added a comment.

In D113612#3140624 <https://reviews.llvm.org/D113612#3140624>, @ldionne wrote:

> Thanks for the patch! Is this implementing a specific LWG issue/paper, or did you just notice that we differed from the spec? I looked but couldn't find anything.

Thanks for the review! I just noticed the diff from the spec.

I can't believe I missed those two cases. I made the changes and added another test case.

I also noticed there's a missing value initialization in the constructor taking an auto_ptr. But I was not able to run the auto_pointer.pass.cpp test because it was marked as unsupported.
Should we update that constructor as well, and if so, how do I run the test?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113612/new/

https://reviews.llvm.org/D113612