[libcxx-commits] [PATCH] D113612: [libc++] Value-initialize unique_ptr's deleter_type

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Thanks for the patch! Is this implementing a specific LWG issue/paper, or did you just notice that we differed from the spec? I looked but couldn't find anything.



================
Comment at: libcxx/include/__memory/unique_ptr.h:187
   _LIBCPP_INLINE_VISIBILITY
   explicit unique_ptr(pointer __p) _NOEXCEPT : __ptr_(__p, __default_init_tag()) {}
 
----------------
We have the same problem here AFAICT.


================
Comment at: libcxx/include/__memory/unique_ptr.h:411
   _LIBCPP_INLINE_VISIBILITY
   explicit unique_ptr(_Pp __p) _NOEXCEPT
       : __ptr_(__p, __default_init_tag()) {}
----------------
And here!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113612/new/

https://reviews.llvm.org/D113612