[libcxx-commits] [PATCH] D113607: [libunwind][AIX] Mark signal_frame.pass.cpp UNSUPPORTED on AIX

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.

LGTM with suggestions.



================
Comment at: libunwind/test/signal_frame.pass.cpp:18
 
-// UNSUPPORTED: libunwind-arm-ehabi
+// UNSUPPORTED: libunwind-arm-ehabi, target=powerpc{{|64}}-ibm-aix
 
----------------
MaskRay wrote:
> I assume that you have checked that `target=powerpc{{|64}}-ibm-aix` work with both `UNSUPPORTED` and `REQUIRES`.
Yes it does -- it's just a normal Lit feature.

Please add a comment explaining:

```
// The AIX assembler does not support CFI directives, which
// are necessary to run this test.
// UNSUPPORTED: target=powerpc{{(64)?}}-ibm-aix
```

I also suggest using `(64)?` instead of `|64` for the regex. It seems more idiomatic to me.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113607/new/

https://reviews.llvm.org/D113607