[libcxx-commits] [PATCH] D114133: [libc++] Minor fixups in the new introsort code.

[Nilay Vaish via Phabricator via libcxx-commits]

nilayvaish added a comment.

So I was writiing https://reviews.llvm.org/D114135 in parallel.  I have added a test which fails with out the change.  I am wondering if we should add it.  Error message from the failed test below:

In file included from llvm-project/build/include/c++/v1/__algorithm/nth_element.h:15,

  from llvm-project/build/include/c++/v1/algorithm:714,
  from llvm-project/libcxx/test/std/algorithms/alg.sorting/alg.sort/sort/sort_comp.pass.cpp:17:

llvm-project/build/include/c++/v1/__algorithm/sort.h: In instantiation of ‘void std::__1::__sort(_RandomAccessIterator, _RandomAccessIterator, _Compare) [with _Compare = unique_ptr_less<int>&; _RandomAccessIterator = int*]’:
llvm-project/build/include/c++/v1/__algorithm/sort.h:543:29:   required from ‘constexpr void std::__1::sort(_RandomAccessIterator, _RandomAccessIterator, _Compare) [with _RandomAccessIterator = std::__1::__wrap_iter<int*>; _Compare = unique_ptr_less<int>]’
llvm-project/libcxx/test/std/algorithms/alg.sorting/alg.sort/sort/sort_comp.pass.cpp:80:73:   required from here
llvm-project/build/include/c++/v1/__algorithm/sort.h:483:21: error: use of deleted function ‘unique_ptr_less<int>::unique_ptr_less(const unique_ptr_less<int>&)’

  483 |   _VSTD::__introsort(__first, __last, __comp, __depth_limit);


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114133/new/

https://reviews.llvm.org/D114133