[libcxx-commits] [PATCH] D113413: Add introsort to avoid O(n^2) behavior and a benchmark for adversarial quick sort input.

[Haowei Wu via Phabricator via libcxx-commits]

haowei added subscribers: phosek, mcgrathr, haowei.
haowei added a comment.

We are seeing build breakages on Fuchsia builders after this change. It complains `definition of implicit copy constructor is deprecated because it has a user-provided copy assignment operator`. Example of the failure can be found at https://ci.chromium.org/ui/p/fuchsia/builders/ci/clang_toolchain.ci.core.arm64-release/b8830264610876104385/overview . It is confirmed through bisection. Code that failed to build can be found at https://fuchsia.googlesource.com/third_party/flatbuffers/+/f22618113aea6d04ed10bcaf28cc3621eea146d2/include/flatbuffers/flatbuffers.h#1154

Would you mind taking a look? We can suppress the error on our end but we still haven't figure out why this change could trigger this error(warning).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113413/new/

https://reviews.llvm.org/D113413