[libcxx-commits] [PATCH] D114109: [libc++] Enable <atomic> when threads are disabled

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision as: Mordante.
Mordante added a comment.

Nice change! LGTM modulo some nits. (Obviously assuming the CI is happy.)



================
Comment at: libcxx/include/__thread/poll_with_backoff.h:59
+// are no other threads to compete with.
+struct __spinning_backoff_policy {
+  _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR
----------------
Should this be marked with `_LIBCPP_TYPE_VIS`?


================
Comment at: libcxx/include/atomic:1524
+    using _Policy = __libcpp_timed_backoff_policy;
+#endif
+    return __libcpp_thread_poll_with_backoff(__test_fn, _Policy());
----------------



================
Comment at: libcxx/test/std/atomics/types.pass.cpp:21
 #include <atomic>
+# include <memory>
+#include <chrono>
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114109/new/

https://reviews.llvm.org/D114109