[libcxx-commits] [PATCH] D110647: [libc++] Resolve missing table_size symbol

Wed Nov 17 07:21:25 PST 2021

muiez added a comment.

In D110647#3122355 <https://reviews.llvm.org/D110647#3122355>, @ldionne wrote:

> In D110647#3122226 <https://reviews.llvm.org/D110647#3122226>, @muiez wrote:
>
>> Any insight as to why the CI is red? It seems to complain about a new symbol being added `_ZNSt3__15ctypeIcE10table_sizeE`, which is defined. However, that is the intention since we want to resolve the missing symbol.
>
> The CI is testing that there are no ABI changes. This patch contains an ABI change, since it adds a symbol. The change is not an ABI *break* so it is acceptable, but it is nonetheless a change. You need to update the ABI lists to contain that symbol.
>
> You can see how to do that here: https://libcxx.llvm.org/Contributing.html#exporting-new-symbols-from-the-library. Basically, go to https://buildkite.com/llvm-project/libcxx-ci/builds/6180#75b25b94-130a-472d-a409-72a7f5507f17 and click on Artifacts. The `libcxx/lib/abi/x86_64-unknown-linux-gnu.libcxxabi.v1.stable.exceptions.no_new_in_libcxx.abilist` file will contain the new symbol for `table_size` -- add it to the corresponding file in `libcxx/`. You'll then need to do the same on macOS (look at the macOS ABI lists in the macOS jobs once the CI gets that far).
>
> Finally, please also add an entry in `libcxx/lib/abi/CHANGELOG.TXT`.

Thanks for the explanation. I will add the commit hash to the `libcxx/lib/abi/CHANGELOG.TXT` once this lands. Comments have been addressed.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110647/new/

https://reviews.llvm.org/D110647