[libcxx-commits] [PATCH] D113876: [libc++] Add missing __format__ attributes

[Mikael Holmén via Phabricator via libcxx-commits]

uabelho added inline comments.


================
Comment at: libcxx/include/__bsd_locale_fallbacks.h:112
 inline
 int __libcpp_snprintf_l(char *__s, size_t __n, locale_t __l, const char *__format, ...) {
     va_list __va;
----------------
ldionne wrote:
> uabelho wrote:
> > ldionne wrote:
> > > I believe we should instead move those to `_LIBCPP_FORMAT_PRINTF`. The usage is documented here: https://clang.llvm.org/docs/AttributeReference.html#format.
> > Would you feel like doing it if it should be fixed in some other way that just disabling the warning?
> > 
> > I really don't know this stuff, I just saw one of our downstream bots signalling there were a bunch of new warnings and saw you disabled warnings this way in your original patch so did the same thing here.
> Yup, no worries. Thanks for bringing that to our attention!
Great! Thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113876/new/

https://reviews.llvm.org/D113876