[libcxx-commits] [PATCH] D113906: [libc++] [test] Add "robust_re_difference_type.compile.pass.cpp" for all the algorithms.

[Konstantin Varlamov via Phabricator via libcxx-commits]

var-const added inline comments.


================
Comment at: libcxx/test/std/algorithms/robust_against_adl.compile.pass.cpp:60
+#endif
+    (void)std::generate(first, last, [](){ return nullptr; });
+    (void)std::generate_n(first, count, [](){ return nullptr; });
----------------
Quuxplusone wrote:
> var-const wrote:
> > Ultranit: omit the empty parentheses?
> Definitely not. :)
Just curious, what's your rationale? I've always seen them as unnecessary boilerplate, so I'm interested to know why you prefer to keep them. To be clear, I'm absolutely fine with keeping them, just interested in your perspective.


================
Comment at: libcxx/test/std/algorithms/robust_against_adl.compile.pass.cpp:82
+    (void)std::rotate_copy(first, mid, last, first2);
+#if TEST_STD_VER > 17
+    (void)std::shift_left(first, last, count);
----------------
Quuxplusone wrote:
> var-const wrote:
> > Just checking: `random_shuffle` is omitted deliberately, right?
> I don't remember my original logic, but yeah, since it's deprecated/removed, I think it's fine to omit.
> `std::shuffle` is also omitted, and I think my logic in that case was just that it was too awkward to define a URBG just for that one call.
Can you please add a brief comment to that effect?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113906/new/

https://reviews.llvm.org/D113906