[libcxx-commits] [PATCH] D113876: [libc++] Silence -Wformat-nonliteral warnings in __bsd_locale_fallbacks.h

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Thanks for looking into this! I missed those because I only built the library on Darwin, and CI passed since those are only warnings 🤦🏼‍♂️.



================
Comment at: libcxx/include/__bsd_locale_fallbacks.h:112
 inline
 int __libcpp_snprintf_l(char *__s, size_t __n, locale_t __l, const char *__format, ...) {
     va_list __va;
----------------
I believe we should instead move those to `_LIBCPP_FORMAT_PRINTF`. The usage is documented here: https://clang.llvm.org/docs/AttributeReference.html#format.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113876/new/

https://reviews.llvm.org/D113876