[libcxx-commits] [PATCH] D109433: [libcxx] [coroutine] Conform coroutine implementation

[Chuanqi Xu via Phabricator via libcxx-commits]

ChuanqiXu marked 2 inline comments as done.
ChuanqiXu added inline comments.


================
Comment at: libcxx/include/__coroutine/noop_coroutine_handle.h:23
+
+#if __has_builtin(__builtin_coro_noop)
+// [coroutine.noop]
----------------
ldionne wrote:
> Can we get rid of this (and similarly in the corresponding test file)?
Only Clang and MSVC implements `__builtin_coro_noop`. GCC uses other tricks. So if we move get rid of this guard, it couldn't compiled by GCC. According to our previous discussion, we decide to support this in later patches.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109433/new/

https://reviews.llvm.org/D109433