[libcxx-commits] [PATCH] D110738: [libc++] [P1614] Implement the first half of [cmp.alg]: strong_order, weak_order, partial_order.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone marked 3 inline comments as done.
Quuxplusone added inline comments.


================
Comment at: libcxx/test/std/language.support/cmp/cmp.alg/strong_order_long_double.verify.cpp:16-18
+// libc++ does not support strong_order(long double, long double) quite yet.
+// This test verifies the error message we give for that case.
+// TODO: remove this test once long double is properly supported.
----------------
This test fails on arm7 (32-bit?) and Win32, where `long double` is 64 bits just like `double`.
It also fails on arm8 (64-bit?) for some reason I can't reproduce on Godbolt.
It also fails on AIX.
@ldionne: Any idea what `XFAIL` lines I should add here? Or shall I just eliminate this test again?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110738/new/

https://reviews.llvm.org/D110738