[libcxx-commits] [PATCH] D113938: [libc++] Remove _LIBCPP_HAS_NO_SPACESHIP_OPERATOR

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Nov 15 14:43:49 PST 2021


Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added a comment.

I do wonder if CI is really going to be green. After all, it's not just that the lexer must support `<=>`, but we rely on the conforming behavior of `=default`, and synthesized candidates, and so on. But if you're really sure that all supported compilers do //all// that stuff, then sure, go for it.



================
Comment at: libcxx/include/compare:158
 template<class _Tp> constexpr weak_ordering weak_order(const _Tp& __lhs, const _Tp& __rhs);
 template<class _Tp> constexpr partial_ordering partial_order(const _Tp& __lhs, const _Tp& __rhs);
 
----------------
Ping on D110738, btw. ;)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113938/new/

https://reviews.llvm.org/D113938



More information about the libcxx-commits mailing list