[libcxx-commits] [PATCH] D113849: [libc++] [NFC] Disable clang-tidy's readability-identifier-naming check

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Nov 15 08:34:43 PST 2021


Mordante accepted this revision as: Mordante.
Mordante added a comment.

It would be interesting to have settings would find real issues in libc++. When we have those I wouldn't mind to enable them. (I'm not sure how feasible that is, since we sometimes write "bad code" on purpose.)

But this check is indeed not useful in libc++ so LGTM. I think it would be nice to keep the commit message more neutral or provide numbers of the number of warnings this removes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113849/new/

https://reviews.llvm.org/D113849



More information about the libcxx-commits mailing list