[libcxx-commits] [PATCH] D113849: [libc++] Make clang-tidy usable in libc++

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Nov 14 17:10:07 PST 2021


Quuxplusone added a comment.

- The commit message seems overconfident. ;) It'd be better to say something about the functionality of the patch, e.g. "[libc++] [NFC] Disable clang-tidy's readability-identifier-naming check."
- Adding this new .clang-tidy file isn't going to automagically enable code-review-spam from clang-tidy on Phab reviews, is it? We've successfully banished clang-format-spam through some black magic I don't understand, so I hope this isn't similar black magic to //enable// a new kind of spam.

LGTM % those comments, though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113849/new/

https://reviews.llvm.org/D113849



More information about the libcxx-commits mailing list