[libcxx-commits] [PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

This broke building ANGLE as part of Qt 5.15 for a mingw target, with the following error:

  ../../../3rdparty/angle/src/libANGLE/renderer/d3d/d3d11/ResourceManager11.cpp:532:38: error: explicit instantiation of 'allocate' does not refer to a function template, variable template, member function, member class, or static data member
  ANGLE_RESOURCE_TYPE_OP(Instantitate, ANGLE_INSTANTIATE_OP)
                                       ^
  ../../../3rdparty/angle/src/libANGLE/renderer/d3d/d3d11/ResourceManager11.h:301:15: note: candidate template ignored: could not match 'GetInitDataFromD3D11<T>' (aka 'typename InitDataType<ResourceTypeFromD3D11<type-parameter-0-0>::Value>::Value') against 'const D3D11_SUBRESOURCE_DATA' 
      gl::Error allocate(Renderer11 *renderer,
                ^
  ../../../3rdparty/angle/src/libANGLE/renderer/d3d/d3d11/ResourceManager11.cpp:358:30: note: candidate template ignored: could not match 'GetInitDataFromD3D11<T>' (aka 'typename InitDataType<ResourceTypeFromD3D11<type-parameter-0-0>::Value>::Value') against 'const D3D11_SUBRESOURCE_DATA'
  gl::Error ResourceManager11::allocate(Renderer11 *renderer,
                               ^

Do you happen to know what's going on here? The files mentioned are https://code.qt.io/cgit/qt/qtbase.git/tree/src/3rdparty/angle/src/libANGLE/renderer/d3d/d3d11/ResourceManager11.cpp?h=5.15.1 and https://code.qt.io/cgit/qt/qtbase.git/tree/src/3rdparty/angle/src/libANGLE/renderer/d3d/d3d11/ResourceManager11.h?h=5.15.1.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110216/new/

https://reviews.llvm.org/D110216