[libcxx-commits] [PATCH] D113663: [libcxxabi/runtimes] Set LLVM_HOST_TRIPLE in runtimes build

Petr Hosek via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Nov 11 22:12:22 PST 2021


phosek added inline comments.


================
Comment at: runtimes/CMakeLists.txt:116-121
 if (NOT LLVM_DEFAULT_TARGET_TRIPLE)
-  include(GetHostTriple)
   get_host_triple(LLVM_DEFAULT_TARGET_TRIPLE)
+  set(LLVM_HOST_TRIPLE ${LLVM_DEFAULT_TARGET_TRIPLE})
+else()
+  get_host_triple(LLVM_HOST_TRIPLE)
 endif()
----------------
We can simplify this by getting the host triple unconditionally.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113663/new/

https://reviews.llvm.org/D113663



More information about the libcxx-commits mailing list