[libcxx-commits] [PATCH] D112012: [benchmarks] Move libcxx's fork of google/benchmark and llvm/utils' under third-party

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

Note that D113503 <https://reviews.llvm.org/D113503> has landed now, so you should rebase onto `main`.



================
Comment at: llvm/CMakeLists.txt:1001
 
+add_llvm_external_project(third-party)
+
----------------
I don't understand why this is needed.


================
Comment at: llvm/cmake/modules/AddLLVM.cmake:1538
   set_property(TARGET ${benchmark_name} PROPERTY FOLDER "Utils")
+  add_dependencies(${benchmark_name} benchmark)
   target_link_libraries(${benchmark_name} PRIVATE benchmark)
----------------
I don't understand why this is needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112012/new/

https://reviews.llvm.org/D112012