[libcxx-commits] [PATCH] D88458: [CMake] Cache the compiler-rt library search results

Thu Nov 4 09:58:59 PDT 2021

phosek added a comment.

In D88458#3108920 <https://reviews.llvm.org/D88458#3108920>, @Abpostelnicu wrote:

> In D88458#3100557 <https://reviews.llvm.org/D88458#3100557>, @phosek wrote:
>
>> In D88458#3100139 <https://reviews.llvm.org/D88458#3100139>, @Abpostelnicu wrote:
>>
>>> In D88458#3095459 <https://reviews.llvm.org/D88458#3095459>, @phosek wrote:
>>>
>>>> In D88458#3093023 <https://reviews.llvm.org/D88458#3093023>, @Abpostelnicu wrote:
>>>>
>>>>> In D88458#3089403 <https://reviews.llvm.org/D88458#3089403>, @phosek wrote:
>>>>>
>>>>>> Properly handle the flags to address the issue seen on some bots when cross-compiling.
>>>>>
>>>>> I don't know if you noticed my previous comment but this again broke the build. It's a tar of the build directory.
>>>>
>>>> I tried reproducing the issue locally using the command you provided but I'm not seeing the same error. Would it be possible to share `CMakeFiles/CMakeError.log` from your build?
>>>
>>> Thanks for looking into this. Please see this <https://firefoxci.taskcluster-artifacts.net/a3TbZn-zRkeOyyzOYJpRZA/0/public/clang/CMakeError.log>.
>>
>> Thanks, I looked at the `CMakeError.log` file but there's nothing out of ordinary. I don't think that the failing `histedit.h` check is a new issue, that seems like the expected behavior.
>>
>> Can I see the full build log somewhere?
>
> Please let me know if this helps https://drive.google.com/file/d/1nzKVJOnYWuXKH1nJufClXCq5QHeJBlVp/view?usp=sharing

I was hoping to see the output from CMake which is not included.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88458/new/

https://reviews.llvm.org/D88458