[libcxx-commits] [PATCH] D109433: [libcxx] [coroutine] Conform coroutine implementation

[Chuanqi Xu via Phabricator via libcxx-commits]

ChuanqiXu added a comment.

When I look into the error message, I find the following error message:

  FAIL: /home/libcxx-builder/.buildkite-agent/builds/344e6285b245-1/llvm-project/libcxx-ci/libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp:247
  GDB printed:
     'std::bitset<258u>'
  Value should match:
     'std::bitset<258(ul)?>'
  FAIL: /home/libcxx-builder/.buildkite-agent/builds/344e6285b245-1/llvm-project/libcxx-ci/libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp:250
  GDB printed:
     'std::bitset<0u>'
  Value should match:
     'std::bitset<0(ul)?>'
  FAIL: /home/libcxx-builder/.buildkite-agent/builds/344e6285b245-1/llvm-project/libcxx-ci/libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp:253
  GDB printed:
     'std::bitset<15u> = {[2] = 1, [3] = 1, [4] = 1, [5] = 1, [6] = 1, [7] = 1, [8] = 1, [9] = 1}'
  Value should match:
     'std::bitset<15(ul)?> = {\\[2\\] = 1, \\[3\\] = 1, \\[4\\] = 1, \\[5\\] = 1, \\[6\\] = 1, \\[7\\] = 1, \\[8\\] = 1, \\[9\\] = 1}'
  FAIL: /home/libcxx-builder/.buildkite-agent/builds/344e6285b245-1/llvm-project/libcxx-ci/libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp:261
  GDB printed:
     'std::bitset<258u> = {[0] = 1, [129] = 1, [132] = 1}'
  Value should match:
     'std::bitset<258(ul)?> = {\\[0\\] = 1, \\[129\\] = 1, \\[132\\] = 1}'

It looks like this is introduced in https://reviews.llvm.org/D113112. @ldionne hi, could you help to look into this? @Quuxplusone Now I think this test failure should be irrelevant with this diff and all other tests are passed. Do you think we should land this after the bug fixed or we could land this now?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109433/new/

https://reviews.llvm.org/D109433