[libcxx-commits] [PATCH] D112976: [libc++][NFC] Inline most of `__vector_base` into `vector`.

[Shafik Yaghmour via Phabricator via libcxx-commits]

shafik added a comment.

Hello,

Just a reminder when we change underlying structure of types in libc++ it is important to run the LLDB test suite. We have many formatters for libc++ and the rely on a lot of internals for the formatting. This case did not break a formatter it did change the type being returned by several member functions.

I had to track down this break using bisect and I just applied a fix: 0d62e31c458526e1db37d11da947e61768c7b522 <https://reviews.llvm.org/rG0d62e31c458526e1db37d11da947e61768c7b522>

Thank you


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112976/new/

https://reviews.llvm.org/D112976