[libcxx-commits] [PATCH] D110261: [libc++][release] Do not force building the runtimes with -fPIC

[James Nagurne via Phabricator via libcxx-commits]

JamesNagurne added a comment.

> As-is, this patch will have the unintended effect that Clang and the
> LLVM libraries (not only the runtime ones like libc++) will also be
> built with -fPIC in the release.

Do you mean that specifying LLVM_ENABLE_RUNTIMES at configure-time causes both llvm/clang and the enabled runtimes (libc++, libc++abi, libunwind, etc) to use the same PIC selection?
The runtimes have a way to use their own configuration. Prefixing a variable with RUNTIMES_ or BUILTINS_ sends that variable to the runtime/builtins build, overwriting the one used to configure LLVM.

https://github.com/llvm/llvm-project/blob/7562c64197acbee60c4bb0d211eb699ad24f5bb8/llvm/runtimes/CMakeLists.txt#L308


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110261/new/

https://reviews.llvm.org/D110261