[libcxx-commits] [PATCH] D113482: [libc++] Implement P1147R1 (Printing volatile T*)

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/include/ostream:58
     basic_ostream& operator<<(const void* p);
+    basic_ostream& operator<<(const volatile void* val);
     basic_ostream& operator<<(basic_streambuf<char_type,traits>* sb);
----------------
Nitpick: add `// C++23`.

I'll do this when committing on your behalf.


================
Comment at: libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/pointer.volatile.pass.cpp:16
+
+// operator<<(const volatile void* val);
+
----------------
Nit: this is missing a return type. I'll fix that upon committing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113482/new/

https://reviews.llvm.org/D113482