[libcxx-commits] [PATCH] D113482: [libc++] Implement P1147R1 (Printing volatile T*)

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

LGTM except for the testing nitpick. Requesting changes so it shows up at the top once you update.



================
Comment at: libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/pointer.pass.cpp:62
     }
     {
         testbuf<char> sb1;
----------------
Sorry for missing that in the first round of review, but the new tests should live in a new file like `pointer.volatile.pass.cpp`, and should show the correct synopsis for what we're testing. You can then mark it as `// UNSUPPORTED: c++03, c++11, c++17, c++20`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113482/new/

https://reviews.llvm.org/D113482