[libcxx-commits] [PATCH] D113403: [libcxx][CI][AIX] Switch to LLVM_ENABLE_RUNTIMES

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libcxx/utils/ci/run-buildbot:116-120
 function generate-cmake-aix() {
     generate-cmake-base \
-          -S "${MONOREPO_ROOT}/llvm" \
-          -DLLVM_ENABLE_PROJECTS="libcxx;libcxxabi" \
+          -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi" \
           "${@}"
 }
----------------
Can we get rid of `generate-cmake-aix` entirely since it is only used in one place?


================
Comment at: libcxxabi/CMakeLists.txt:522-526
+# On AIX, avoid picking up VMX extensions(i.e. vec_malloc) which would change
+# the default alignment of the allocators here.
+if (UNIX AND ${CMAKE_SYSTEM_NAME} MATCHES "AIX")
+  add_definitions("-D_XOPEN_SOURCE=700")
+endif()
----------------
Is this a different workaround for https://reviews.llvm.org/D112168?


================
Comment at: libcxxabi/CMakeLists.txt:524
+# the default alignment of the allocators here.
+if (UNIX AND ${CMAKE_SYSTEM_NAME} MATCHES "AIX")
+  add_definitions("-D_XOPEN_SOURCE=700")
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113403/new/

https://reviews.llvm.org/D113403