[libcxx-commits] [PATCH] D113481: [libcxx] Add a dependency on unwind for tests, if LIBCXXABI_USE_LLVM_UNWINDER is set

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Nov 9 05:29:15 PST 2021


mstorsjo created this revision.
mstorsjo added a reviewer: ldionne.
Herald added a subscriber: mgorny.
mstorsjo requested review of this revision.
Herald added a project: libc++.
Herald added a reviewer: libc++.

Normally when LIBCXXABI_USE_LLVM_UNWINDER is set, the cxx target in
itself also depends on unwind, but if only building a static libcxx,
building libcxx doesn't build libunwind.

This is an alternative to D113467 <https://reviews.llvm.org/D113467>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D113481

Files:
  libcxx/CMakeLists.txt


Index: libcxx/CMakeLists.txt
===================================================================
--- libcxx/CMakeLists.txt
+++ libcxx/CMakeLists.txt
@@ -961,6 +961,10 @@
   list(APPEND LIBCXX_TEST_DEPS cxx_external_threads)
 endif()
 
+if (LIBCXXABI_USE_LLVM_UNWINDER)
+  list(APPEND LIBCXX_TEST_DEPS unwind)
+endif()
+
 if (LIBCXX_INCLUDE_BENCHMARKS)
   add_subdirectory(benchmarks)
 endif()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D113481.385785.patch
Type: text/x-patch
Size: 393 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20211109/a7fbe51f/attachment.bin>


More information about the libcxx-commits mailing list