[libcxx-commits] [PATCH] D109433: [libcxx] [coroutine] Conform coroutine implementation

[Chuanqi Xu via Phabricator via libcxx-commits]

ChuanqiXu added a comment.

In D109433#3116176 <https://reviews.llvm.org/D109433#3116176>, @Mordante wrote:

> In D109433#3114657 <https://reviews.llvm.org/D109433#3114657>, @ChuanqiXu wrote:
>
>> In D109433#3114239 <https://reviews.llvm.org/D109433#3114239>, @Mordante wrote:
>>
>>> The build system uses https://apt.llvm.org/ for its packages. This isn't updated nightly so it might be the build used an old version. The current timestamp of the build is 20211106103030. @ChuanqiXu can you rebase this patch to trigger the CI again?
>>
>> @Mordante Due to my system is not Debian/Ubuntu, I couldn't test the package in the link locally. And I sent another diff in: https://reviews.llvm.org/D113170. It is the same with this one except that it would check the macro '__cpp_impl_coroutine'. And the result shows that the compiler in the CI still didn't emit macro   '__cpp_impl_coroutine'. Could you help to check the compiler in the CI system or tell me how to test the timestamp of the compiler in the CI system? Thanks.
>
> I run Debian so I tested locally which version was available in apt.llvm.org. I just did a quick test with the Docker image we run on our CI. There the version installed is of the 27th of October. When I manually update in Docker I get a binary of the 5th of November. (Not sure why Ubuntu has a one day older build than Debian). So it seems our CI uses a version of Clang before D108696 <https://reviews.llvm.org/D108696> landed. I have some suspicions, but @ldionne knows more about our CI.

Got it. Thanks.

In D109433#3116311 <https://reviews.llvm.org/D109433#3116311>, @ldionne wrote:

> In D109433#3116176 <https://reviews.llvm.org/D109433#3116176>, @Mordante wrote:
>
>> I run Debian so I tested locally which version was available in apt.llvm.org. I just did a quick test with the Docker image we run on our CI. There the version installed is of the 27th of October. When I manually update in Docker I get a binary of the 5th of November. (Not sure why Ubuntu has a one day older build than Debian). So it seems our CI uses a version of Clang before D108696 <https://reviews.llvm.org/D108696> landed. I have some suspicions, but @ldionne knows more about our CI.
>
> Long story short, our CI doesn't get an updated version of the compiler on apt.llvm.org automatically. They cache the Docker image and don't rebuild it unless the Dockerfile changes AFAICT. This isn't great -- we should always use the Dockerfile in the repo to run the build, but there are hurdles to setting that up. I'll manually change the Dockerfile to trigger an image rebuild -- we should pick up the latest apt.llvm.org compiler, which I think should include D108696 <https://reviews.llvm.org/D108696>.

It looks like that the CI didn't update the compiler yet. May I ask when would it be OK to use  a later version?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109433/new/

https://reviews.llvm.org/D109433