[libcxx-commits] [PATCH] D110349: [libcxx][SystemZ][z/OS] Added are_threads_enabled and has_spawned_other_threads to __threading_support

[Daniel McIntosh via Phabricator via libcxx-commits]

DanielMcIntosh-IBM added inline comments.


================
Comment at: libcxx/include/__support/ibm/ceeedb.h:46
+  const unsigned char CEEEDB_POSIX = '\x04';
+  return __libcpp_ceeedb_flags() & CEEEDB_POSIX;
+}
----------------
Quuxplusone wrote:
> Nits: Surely `'\x04'` is more confusing than `4`?
> Should you guard against the user doing `#define CEEEDB_POSIX 42` before including this header? Ditto for all non-reserved identifiers used in this file (lines 22–26, 32–36, 40, 45).
The CEE prefix is reserved on z/OS for Language Environment external names, so no we don't need to guard against it. I will however add a `#error` message for if the header is included when not on z/OS


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110349/new/

https://reviews.llvm.org/D110349