[libcxx-commits] [PATCH] D70631: Microsoft's floating-point to_chars powered by Ryu and Ryu Printf

[Mark de Wever via Phabricator via libcxx-commits]

Mordante planned changes to this revision.
Mordante added inline comments.


================
Comment at: libcxx/src/ryu/README.txt:7
+The code has been modified by Stephan T. Lavavej of Microsoft for usage in
+std::to_chars. This modified code has been contributed by Microft for includion
+in libc++.
----------------
h-vetinari wrote:
> h-vetinari wrote:
> > 
> Not sure if this comment is properly visible (not much experience on Phabricator), but this should be "by Microsoft for inclusion" instead of "by Microft for includion"
Thanks for the ping. It's visible and indeed not done yet, that's why the items isn't marked as done yet. Yesterday I wanted to get the CI done before I left. Once the CI is green I want to address all open issues and start to get the patch ready for review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70631/new/

https://reviews.llvm.org/D70631