[libcxx-commits] [PATCH] D113364: [libc++] Adds missing forward_list merge tests.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added a comment.

LGTM assuming these tests are all basically copied from the `std::list` tests.



================
Comment at: libcxx/test/std/containers/sequences/forwardlist/forwardlist.ops/merge_lvalue_pred.pass.cpp:65
+#endif
+    P po[3] = {&*io[0], &*io[1], &*io[2]};
+
----------------
I assume this is copied from an existing test, because otherwise `typedef T* P;` is certainly overkill. ;) No complaints if we're just matching somewhere else, though.


================
Comment at: libcxx/test/std/containers/sequences/forwardlist/forwardlist.ops/merge_rvalue.pass.cpp:9
+
+// UNSUPPORTED: c++03
+
----------------
Honestly this probably works in c++03 mode, too, doesn't it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113364/new/

https://reviews.llvm.org/D113364