[libcxx-commits] [PATCH] D112654: [libc++] Use addressof in list.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added a comment.

Seems reasonable to me.



================
Comment at: libcxx/test/std/containers/sequences/list/list.modifiers/erase_iter.addressof.compile.pass.cpp:22-23
+  std::list<operator_hijacker> l;
+  std::list<operator_hijacker>::const_iterator it;
+  it = l.erase(l.begin());
+}
----------------
Nit: You don't do `it =` for `insert`; I don't think you need to do it for `erase`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112654/new/

https://reviews.llvm.org/D112654