[libcxx-commits] [PATCH] D113161: [libc++] Implement P1989R2: range constructor for string_view

[Joe Loser via Phabricator via libcxx-commits]

jloser added inline comments.


================
Comment at: libcxx/test/std/strings/string.view/string.view.deduct/range.pass.cpp:8
 //===----------------------------------------------------------------------===//
-// UNSUPPORTED: c++03, c++11, c++14, c++17
+// UNSUPPORTED: c++03, c++11, c++14, c++17, c++20
 // UNSUPPORTED: libcpp-no-concepts
----------------
Quuxplusone wrote:
> IIUC, Phab is confused here: you're not //actually// removing any test coverage here, you're just adding a second copy of this file. Right?
It's a `git mv` of the file from `libcxx/test/std/strings/string.view/string.view.cons/deduct.pass.cpp` to `libcxx/test/std/strings/string.view/string.view.deduct/iterator_sentinel.pass.cpp`. There is no loss in coverage.

There isn't necessarily precedence for this (having a `deduct` subdirectory - we usually have a single `deduct.pass.cpp`). However, I find this pattern a bit nicer when there's several out-of-function-line `static_assert`s and such. Having it all be comingled in a single `deduct.pass.cpp` didn't seem as nice.  WDYT?




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113161/new/

https://reviews.llvm.org/D113161