[libcxx-commits] [PATCH] D70631: Microsoft's floating-point to_chars powered by Ryu and Ryu Printf

[Mark de Wever via Phabricator via libcxx-commits]

Mordante planned changes to this revision.
Mordante added a comment.

Thanks for sharing the motivation for enabling integral version of `to_chars` in C++11 @mclow.lists.



================
Comment at: libcxx/src/CMakeLists.txt:2
 set(LIBCXX_LIB_CMAKEFILES_DIR "${CMAKE_CURRENT_BINARY_DIR}${CMAKE_FILES_DIRECTORY}"  PARENT_SCOPE)
+include_directories(${CMAKE_CURRENT_SOURCE_DIR})
 
----------------
ldionne wrote:
> Mordante wrote:
> > @ldionne This seems to be required since not all build do this automatically.
> > Should I make this a separate commit?
> Yes, I believe this should be a separate commit. We also probably want to `target_include_directories` with `cxx_shared` and `cxx_static` instead of using `include_directories` globally.
It should indeed be `target_include_directories`, however for an initial test using the global version is much easier. For now I keep it in this patch. Once all is green I'll move this to its own patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70631/new/

https://reviews.llvm.org/D70631