[libcxx-commits] [PATCH] D113181: [libcxxabi][ARM] Make CXX_end_cleanup compatible with Armv6-M

[Vlad Vereschaka via Phabricator via libcxx-commits]

vvereschaka added a comment.

Hi @danielkiss,

same as for @thakis, these changes have broken the armv7 toolchain builder

  11.219 [3/3/902] Linking CXX shared library C:\buildbot\as-builder-1\x-armv7l\build\lib\armv7-unknown-linux-gnueabihf\libc++abi.so.1.0
  FAILED: C:/buildbot/as-builder-1/x-armv7l/build/lib/armv7-unknown-linux-gnueabihf/libc++abi.so.1.0 
  cmd.exe /C "cd . && C:\buildbot\as-builder-1\x-armv7l\build\.\bin\clang++.exe --target=armv7-unknown-linux-gnueabihf -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wstring-conversion -Wmisleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections --target=armv7-unknown-linux-gnueabihf --sysroot=C:/buildbot/.arm-ubuntu  -O3 -DNDEBUG  -Wl,-z,nodelete -Wl,--color-diagnostics  --target=armv7-unknown-linux-gnueabihf --sysroot=C:/buildbot/.arm-ubuntu -nostdlib++ -shared -Wl,-soname,libc++abi.so.1 -o C:\buildbot\as-builder-1\x-armv7l\build\lib\armv7-unknown-linux-gnueabihf\libc++abi.so.1.0 libcxxabi/src/CMakeFiles/cxxabi_shared.dir/cxa_aux_runtime.cpp.o libcxxabi/src/CMakeFiles/cxxabi_shared.dir/cxa_default_handlers.cpp.o libcxxabi/src/CMakeFiles/cxxabi_shared.dir/cxa_demangle.cpp.o libcxxabi/src/CMakeFiles/cxxabi_shared.dir/cxa_exception_storage.cpp.o libcxxabi/src/CMakeFiles/cxxabi_shared.dir/cxa_guard.cpp.o libcxxabi/src/CMakeFiles/cxxabi_shared.dir/cxa_handlers.cpp.o libcxxabi/src/CMakeFiles/cxxabi_shared.dir/cxa_vector.cpp.o libcxxabi/src/CMakeFiles/cxxabi_shared.dir/cxa_virtual.cpp.o libcxxabi/src/CMakeFiles/cxxabi_shared.dir/stdlib_exception.cpp.o libcxxabi/src/CMakeFiles/cxxabi_shared.dir/stdlib_stdexcept.cpp.o libcxxabi/src/CMakeFiles/cxxabi_shared.dir/stdlib_typeinfo.cpp.o libcxxabi/src/CMakeFiles/cxxabi_shared.dir/abort_message.cpp.o libcxxabi/src/CMakeFiles/cxxabi_shared.dir/fallback_malloc.cpp.o libcxxabi/src/CMakeFiles/cxxabi_shared.dir/private_typeinfo.cpp.o libcxxabi/src/CMakeFiles/cxxabi_shared.dir/cxa_exception.cpp.o libcxxabi/src/CMakeFiles/cxxabi_shared.dir/cxa_personality.cpp.o libcxxabi/src/CMakeFiles/cxxabi_shared.dir/cxa_thread_atexit.cpp.o  -Wl,-rpath,$ORIGIN/../lib  C:/buildbot/as-builder-1/x-armv7l/build/lib/clang/14.0.0/lib/armv7-unknown-linux-gnueabihf/libclang_rt.builtins.a  C:/buildbot/as-builder-1/x-armv7l/build/lib/armv7-unknown-linux-gnueabihf/libunwind.a  -lpthread  -lc  C:/buildbot/as-builder-1/x-armv7l/build/lib/clang/14.0.0/lib/armv7-unknown-linux-gnueabihf/libclang_rt.builtins.a  -ldl  -lpthread && cd ."
  ld.lld: error: relocation R_ARM_ABS32 cannot be used against symbol '_Unwind_Resume'; recompile with -fPIC
  >>> defined in C:/buildbot/as-builder-1/x-armv7l/build/lib/armv7-unknown-linux-gnueabihf/libunwind.a(Unwind-EHABI.cpp.o)
  >>> referenced by cxa_exception.cpp
  >>>               libcxxabi/src/CMakeFiles/cxxabi_shared.dir/cxa_exception.cpp.o:(.text.__cxa_end_cleanup+0x18)
  clang++: error: linker command failed with exit code 1 (use -v to see invocation)

https://lab.llvm.org/buildbot/#/builders/60/builds/5303


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113181/new/

https://reviews.llvm.org/D113181