[libcxx-commits] [PATCH] D98334: [libcxx] Fix hang in try_acquire with __atomic_semaphore_base

Fri Nov 5 12:50:30 PDT 2021

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

In D98334#3110625 <https://reviews.llvm.org/D98334#3110625>, @Quuxplusone wrote:

> @ldionne, now that we're using `__atomic_semaphore_base` unconditionally, I think this patch has become super important. I confirm that the new test really does hang forever on my Macbook, and that this change to `<semaphore>` fixes the hang.
>
> I think we should land this ASAP in both `main` and 13.x (assuming you're still planning to cherry-pick D110110 <https://reviews.llvm.org/D110110>). Having D110110 <https://reviews.llvm.org/D110110> without this patch too, is a pretty bad state to be in.

Agreed. Thanks for rebasing, Arthur. Let's ship this and cherry-pick to `13.x`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98334/new/

https://reviews.llvm.org/D98334