[libcxx-commits] [libcxx] 2d8ec3c - [libcxx] [test] Narrow down XFAILs regarding a MSVC mode specific bug to "windows-dll && msvc"

Martin Storsjö via libcxx-commits libcxx-commits at lists.llvm.org
Fri Nov 5 12:43:54 PDT 2021


Author: Martin Storsjö
Date: 2021-11-05T21:43:29+02:00
New Revision: 2d8ec3c61d3c2d47b303187bb882ca23544f6fc5

URL: https://github.com/llvm/llvm-project/commit/2d8ec3c61d3c2d47b303187bb882ca23544f6fc5
DIFF: https://github.com/llvm/llvm-project/commit/2d8ec3c61d3c2d47b303187bb882ca23544f6fc5.diff

LOG: [libcxx] [test] Narrow down XFAILs regarding a MSVC mode specific bug to "windows-dll && msvc"

These tests don't fail when only windows-dll is set in mingw mode, as the
bug is specific to MSVC mode.

Differential Revision: https://reviews.llvm.org/D112348

Added: 
    

Modified: 
    libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/hash.pass.cpp
    libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/compare.pass.cpp
    libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/hash.pass.cpp
    libcxx/test/std/localization/locales/locale/locale.operators/compare.pass.cpp

Removed: 
    


################################################################################
diff  --git a/libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/hash.pass.cpp b/libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/hash.pass.cpp
index 83757636e051b..383b978355d43 100644
--- a/libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/hash.pass.cpp
+++ b/libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/hash.pass.cpp
@@ -9,7 +9,7 @@
 // REQUIRES: locale.en_US.UTF-8
 
 // https://llvm.org/PR41018
-// XFAIL: windows-dll
+// XFAIL: windows-dll && msvc
 
 // <locale>
 

diff  --git a/libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/compare.pass.cpp b/libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/compare.pass.cpp
index a3023cf9ba363..8028b44465917 100644
--- a/libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/compare.pass.cpp
+++ b/libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/compare.pass.cpp
@@ -7,7 +7,7 @@
 //===----------------------------------------------------------------------===//
 
 // https://llvm.org/PR41018
-// XFAIL: windows-dll
+// XFAIL: windows-dll && msvc
 
 // <locale>
 

diff  --git a/libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/hash.pass.cpp b/libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/hash.pass.cpp
index 7a298c5dab907..7bcfe917f9497 100644
--- a/libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/hash.pass.cpp
+++ b/libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/hash.pass.cpp
@@ -7,7 +7,7 @@
 //===----------------------------------------------------------------------===//
 
 // https://llvm.org/PR41018
-// XFAIL: windows-dll
+// XFAIL: windows-dll && msvc
 
 // <locale>
 

diff  --git a/libcxx/test/std/localization/locales/locale/locale.operators/compare.pass.cpp b/libcxx/test/std/localization/locales/locale/locale.operators/compare.pass.cpp
index a93aa18224616..c435f86f7e9e7 100644
--- a/libcxx/test/std/localization/locales/locale/locale.operators/compare.pass.cpp
+++ b/libcxx/test/std/localization/locales/locale/locale.operators/compare.pass.cpp
@@ -7,7 +7,7 @@
 //===----------------------------------------------------------------------===//
 
 // https://llvm.org/PR41018
-// XFAIL: windows-dll
+// XFAIL: windows-dll && msvc
 
 // <locale>
 


        


More information about the libcxx-commits mailing list